Security Fix: Integer Overflow or Wraparound in Timeout Conversions

Alert Numbers: #413, #414, #415, #416, #417, #418
Severity: HIGH
Rule: G115 - integer overflow conversion uint64 → int64
Tool: gosec (Golang security checks)

Vulnerability Description

Gosec detected 6 HIGH severity integer overflow vulnerabilities where uint and uint64 values were being converted directly to int without checking for potential overflow. This can lead to:

• Undefined behavior on systems where the value exceeds math.MaxInt
• Incorrect timeout values causing unexpected behavior
• Potential security issues from wraparound behavior

Affected Locations:

1. pkg/workflow/frontmatter_extraction_metadata.go:162 (Alert [Custom Engine Test] Test Pull Request - Custom Engine Safe Output #418 - uint conversion in extractToolsTimeout)
2. pkg/workflow/frontmatter_extraction_metadata.go:164 (Alert [Custom Engine Test] Test Pull Request - Custom Engine Safe Output #416 - uint64 conversion in extractToolsTimeout)
3. pkg/workflow/frontmatter_extraction_metadata.go:190 (Alert [Custom Engine Test] Test Pull Request - Custom Engine Safe Output #417 - uint conversion in extractToolsStartupTimeout)
4. pkg/workflow/frontmatter_extraction_metadata.go:192 (Alert [Custom Engine Test] Test Pull Request - Custom Engine Safe Output #415 - uint64 conversion in extractToolsStartupTimeout)
5. pkg/workflow/safe_inputs_parser.go:214 (Alert [Custom Engine Test] Test Issue Created by Custom Engine #414 - uint64 conversion in ParseSafeInputsFromFrontmatter)
6. pkg/workflow/safe_inputs_parser.go:398 (Alert [Custom Engine Test] Test Pull Request - Custom Engine Safe Output #413 - uint64 conversion in MergeSafeInputs)

Fix Applied

Added safe conversion helper functions that check for overflow before converting:

frontmatter_extraction_metadata.go:

// safeUintToInt safely converts uint to int, returning 0 if overflow would occur
func safeUintToInt(u uint) int {
	if u > math.MaxInt {
		return 0 // Return 0 (engine default) if value would overflow
	}
	return int(u)
}

// safeUint64ToInt safely converts uint64 to int, returning 0 if overflow would occur
func safeUint64ToInt(u uint64) int {
	if u > math.MaxInt {
		return 0 // Return 0 (engine default) if value would overflow
	}
	return int(u)
}

safe_inputs_parser.go:

// safeUint64ToIntForTimeout safely converts uint64 to int for timeout values
func safeUint64ToIntForTimeout(u uint64) int {
	if u > math.MaxInt {
		return 0 // Return 0 (engine default) if value would overflow
	}
	return int(u)
}

Applied these safe conversions to all 6 problematic conversions.

Security Best Practices Applied

✅ Overflow Detection: Check if value exceeds math.MaxInt before conversion
✅ Safe Fallback: Return 0 (engine default timeout) if overflow would occur
✅ No Breaking Changes: Behavior is identical for valid values
✅ Defensive Programming: Follows Go best practices for type conversions
✅ G115 Compliance: Satisfies gosec security scanner requirements

Testing

✅ All tests pass: go test ./pkg/workflow/... succeeds
✅ Build successful: go build ./pkg/workflow/... passes without errors
✅ No breaking changes: Normal operation unchanged for valid timeout values
✅ Overflow handling: Values that would overflow safely default to 0

Impact Assessment

Risk: Minimal
Breaking Changes: None
Backwards Compatibility: Full
Performance: Negligible overhead (single integer comparison per conversion)

The fix only adds overflow checking before type conversion. For valid timeout values (which will always be well below math.MaxInt in practice), the behavior is identical. For edge cases where overflow would occur, the function now safely returns 0 instead of causing undefined behavior.

Why This Fix Is Important

1. Prevents Undefined Behavior: Integer overflow in Go can lead to unexpected results
2. Platform Independence: Ensures code works correctly across different architectures
3. Security Best Practice: Validates numeric conversions to prevent vulnerabilities
4. Satisfies Security Scanners: Eliminates 6 HIGH severity gosec alerts
5. Defensive Programming: Shows proper type conversion patterns for similar cases

Files Modified

• pkg/workflow/frontmatter_extraction_metadata.go:

  • Added safeUintToInt() and safeUint64ToInt() helper functions
  • Applied safe conversions in extractToolsTimeout() (lines 179, 181)
  • Applied safe conversions in extractToolsStartupTimeout() (lines 207, 209)

• pkg/workflow/safe_inputs_parser.go:

  • Added safeUint64ToIntForTimeout() helper function
  • Applied safe conversion in ParseSafeInputsFromFrontmatter() (line 224)
  • Applied safe conversion in MergeSafeInputs() (line 408)

References

• CodeQL Alerts:
  • https://github.com/githubnext/gh-aw/security/code-scanning/413
  • https://github.com/githubnext/gh-aw/security/code-scanning/414
  • https://github.com/githubnext/gh-aw/security/code-scanning/415
  • https://github.com/githubnext/gh-aw/security/code-scanning/416
  • https://github.com/githubnext/gh-aw/security/code-scanning/417
  • https://github.com/githubnext/gh-aw/security/code-scanning/418
• Gosec G115: Integer Overflow or Wraparound
• CWE-190: Integer Overflow or Wraparound
• Go math package: [math.MaxInt constant]((redacted)

AI generated by Security Fix PR